Skip to content

vah264enc: Fixes and enhacenments

Víctor Manuel Jáquez Leal requested to merge vjaquez/gstreamer:va-encoder-h264-fixes into main 
vah264enc: Remove GST_PARAM_CONDITIONALLY_AVAILABLE.

Since it's used only when the property is conditionally installed, and
these parameters are always installed.
va: encoder: Clean dead code.
va: encoder: Fix error code path when open.
vah264enc: Remove preferred_output_delay.

In the current state of the encoder it's just dead code.
vah264enc: Avoid mapping coded buffer twice.

Currently for copying the coded buffer onto a GStreamer buffer, the
coded buffer is mapped two times: one for getting the size, and later
for do the actual copy. We can avoid this by doing directly in the
element rather than in the general encoder object.
vah264enc: Single parameter array per picture.

There's no need, at least in H.264, to hold a global parameter array,
since there's no need to submit SPS, trellis, hdr or quality in every
buffer, but only on IDR ones.
va: Fix log message

cc: @He_Junyan

Edited by Víctor Manuel Jáquez Leal

Merge request reports