Skip to content

webrtcbin: Fix retransmissions on video sender side

Jakub Vaněk requested to merge linuxtardis/gstreamer:bugfix/webrtcbin-rtprtxsend into main

The _set_rtx_ptmap_from_stream() internally relies on the stream->rtxsend pointer being non-NULL. However, the modified part of the code only proceeds when stream->rtxsend is NULL. The result was that the payload type map was not set on the rtprtxsend element. Due to this, GStreamer couldn't respond to retransmission requests.

To fix this, the assignment is moved before the call. This is similar to how the stream->rtxreceive element is created.

Tested on GStreamer 1.18.5: with this patch, webrtcbin successfully responds to retransmission requests from the peer.

Edited by Jakub Vaněk

Merge request reports