Skip to content

filesink: Implement workaround for some (network) filesystems that spuriously...

Sebastian Dröge requested to merge slomo/gstreamer:filesink-eaccess into master

filesink: Implement workaround for some (network) filesystems that spuriously return EACCES on write

This seems to happen when another client is accessing the file at the same time, and retrying after a short amount of time solves it.

Sometimes partial data is written at that point already but we have no idea how much it is, or if what was written is correct (it sometimes isn't) so we always first seek back to the current position and repeat the whole failed write.

It happens at least on Linux and macOS on SMB/CIFS and NFS file systems.

Between write attempts that failed with EACCES we wait 10ms, and after enough consecutive tries that failed with EACCES we simply time out.

In theory a valid EACCES for files to which we simply have no access should've happened already during the call to open(), except for NFS (see open(2)).

This can be enabled with the new max-eaccess-retry-timeout property, and a new o-sync boolean property was added to open the file in O_SYNC mode as without that it's not guaranteed that we get EACCES for the actual writev() call that failed but might only get it at a later time.

Fixes #305 (closed)

Merge request reports