Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gstreamer gstreamer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 712
    • Issues 712
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 373
    • Merge requests 373
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GStreamer
  • gstreamergstreamer
  • Merge requests
  • !1269

identity: Fix crash when receiving a gap event outside the current segment

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Vivia Nikolaidou requested to merge vivia/gstreamer:identity_gasp_outside_segment into main Oct 29, 2021
  • Overview 7
  • Commits 1
  • Pipelines 6
  • Changes 1

We were checking if the start time of the gap event was GST_CLOCK_TIME_NONE, which is superfluous because that cannot happen, and then not checking if it was NONE after gst_segment_to_running_time, which caused a crash if an identity received a gap event fully or partially outside the current segment.

This patch was done in cooperation with: Jan Alexander Steffens (heftig) jan.steffens@ltnglobal.com

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: identity_gasp_outside_segment