Skip to content

Draft: kmssink: Fixing issues when used with omx decoder

Stéphane Cerveau requested to merge dabrain34/gstreamer:gst-plugins-bad-dab_fix_kmssink_assert into main

Copied from https://gitlab.freedesktop.org//gstreamer/gst-plugins-bad/-/merge_requests/1028

The render width/height and the vinfo was only saved upon renegotiation. This fixes the problem by saving this metadata at the same time the buffer is saved. The saved copy of this is needed for expose() and drain() virtual functions. This fixes various assertion that happens on drain query.

Related to the given pipeline:

$ gst-launch-1.0 -v videotestsrc num-buffers=1 ! video/x-raw,format=NV12,width=320,height=240, framerate=60/1 ! omxh264enc ! omxh264dec ! fpsdisplaysink name=fpssink text-overlay=false video-sink="kmssink bus-id="a0070000.v_mix fullscreen-overlay=1 plane-id=32

Merge request reports