Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gstreamer gstreamer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 920
    • Issues 920
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 433
    • Merge requests 433
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GStreamerGStreamer
  • gstreamergstreamer
  • Issues
  • #603
Closed
Open
Issue created Aug 31, 2020 by Vivia Nikolaidou@vivia🦆Maintainer0 of 1 checklist item completed0/1 checklist item

aggregator API is inherently racy

The following discussion from gst-plugins-good!711 (merged) should be addressed:

  • @meh started a discussion: (+1 comment)

    Hm, what if the pad gets flush stopped and receives a new buffer in the interval? In that case, we may end up not muxing the "best" pad. The alternative solution is to keep a reference to the "best" buffer alongside the best pad, and call drop_buffer() on it once actually processed.

Basically:

  • @slomo said:

    The only thing you can do is to pop() and then use up the buffer or queue it up locally. Everything else is racy :) So peek() and drop() are useless API and we just noticed that the aggregator API is bad 🤪

Edited Aug 31, 2020 by Vivia Nikolaidou
Assignee
Assign to
Time tracking