Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gstreamer gstreamer
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 922
    • Issues 922
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 439
    • Merge requests 439
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GStreamerGStreamer
  • gstreamergstreamer
  • Issues
  • #271
Closed
Open
Issue created Jan 18, 2018 by Bugzilla Migration User@bugzilla-migration

basetransform: set_passthrough() not doing what the doc says

Submitted by Nicolas Dufresne @ndufresne

Link to original bug (#792645)

Description

The doc says:

  • Always %TRUE for filters which don't implement either a transform
  • or transform_ip method.

While the implementation is no-op in the case we pass FALSE and that conditions is met:

if (!passthrough) {
if (bclass->transform_ip || bclass->transform)
trans->priv->passthrough = FALSE;
} else {
trans->priv->passthrough = TRUE;
}

It's also a weird condition to check for filters that only wants to implement submit_input_buffer() and generate_output(), as they need to place a useless stub for one of the transform function in order to make it behave properly.

Assignee
Assign to
Time tracking