Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
gstreamer
gstreamer
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 405
    • Issues 405
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 79
    • Merge Requests 79
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GStreamer
  • gstreamergstreamer
  • Issues
  • #183

Closed
Open
Opened Aug 18, 2016 by Bugzilla Migration User@bugzilla-migration

GST_PARAM_USER_SHIFT should represent minimum shift count

Submitted by Heinrich Fink @heinrich.fink

Link to original bug (#770079)

Description

Created attachment 333552
Do not shift GST_PARAM_USER_SHIFT

The following code would rightfully result in a compiler warning:

#define TME_API_PARAM_EXPOSED (1 << (GST_PARAM_USER_SHIFT + 1))

warning: shift count >= width of type [-Wshift-count-overflow]
if ((pspec->flags & TME_API_PARAM_EXPOSED) == 0)
^~~~~~~~~~~~~~~~~~~~~
... because GST_PARAM_USER_SHIFT is already a shifted high integer value. See attached patch for a fix to restore the expected behavior of GST_PARAM_USER_SHIFT.

Patch 333552, "Do not shift GST_PARAM_USER_SHIFT":
0001-paramspecs-Do-not-shift-GST_PARAM_USER_SHIFT-itself.patch

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: gstreamer/gstreamer#183