GST_PARAM_USER_SHIFT should represent minimum shift count
Submitted by Heinrich Fink @heinrich.fink
Link to original bug (#770079)
Description
Created attachment 333552
Do not shift GST_PARAM_USER_SHIFT
The following code would rightfully result in a compiler warning:
#define TME_API_PARAM_EXPOSED (1 << (GST_PARAM_USER_SHIFT + 1))
warning: shift count >= width of type [-Wshift-count-overflow]
if ((pspec->flags & TME_API_PARAM_EXPOSED) == 0)
^~~~~~~~~~~~~~~~~~~~~
... because GST_PARAM_USER_SHIFT is already a shifted high integer value. See attached patch for a fix to restore the expected behavior of GST_PARAM_USER_SHIFT.
Patch 333552, "Do not shift GST_PARAM_USER_SHIFT":
0001-paramspecs-Do-not-shift-GST_PARAM_USER_SHIFT-itself.patch