Incorrect line endings in the Windows CI image checkout
I open this issue to write down what I found so far, as it will hit the Windows CI once meson is upgraded with support for
diff_files in wrap. I tried the update in a branch and I had to roll back since all wraps with diff_files were failing to apply their patches.
After seeing the failures in the CI, I was able to reproduce the error locally and it's caused when git changes the line endings from LF to CRLF, for example when
auto instead of
The first thing I did was checking that git is correctly configured in the Windows image:
✅It is installed with the
git config --get core.autocrlfreturns
I than tried looking at the line endings:
(Get-Content subprojects/packagefiles/pango-1.50.12/0001-meson-Fix-pangoft2.pc-when-using-freetype-and-fontco.patch -Raw) -match "\r\n$"returns
That means that for some reason, the line endings are still not correct.