Skip to content
  • Tim-Philipp Müller's avatar
    value: avoid duplicates when intersecting lists · 507fc9ce
    Tim-Philipp Müller authored
    Fixes negotiation taking a ridiculous amount of
    time (multiple 10s of seconds on a core2) when
    there are duplicate entries in lists.
    
    Could have a negative performance impact on other
    scenarios because we now have to iterate the
    dest list to avoid duplicates, but we don't
    have a lot of lists any more these days, and
    they tend to be small anyway. The negatives
    are hopefully countered by the positive effects
    of reducing the list length early on in the
    process. And in any case, it's the right thing
    to do.
    
    Based on patch by Andre Moreira Magalhaes.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=684981
    507fc9ce