Skip to content

plugin: encode: set allowed_sinkpad_caps to empty.

He Junyan requested to merge He_Junyan/gstreamer-vaapi:allowed_sinkpad_caps into master

We now set encode->allowed_sinkpad_caps to NULL if we fail to get surfaces formats. This causes two problem:

  1. gst_video_encoder_proxy_getcaps use NULL as its caps parameter, which changes its behavior. It will use encode's sinkpad template rather than empty caps to do the clip job. So even if we fail to set allowed_sinkpad_caps, gst_video_encoder_proxy_getcaps can still return valid caps.
  2. We should just set the allowed_sinkpad_caps once. The NULL point make the ensure_allowed_sinkpad_caps function works again and again.

Merge request reports