video/timecode: Use mem::ManuallyDrop to prevent a double unref of the daily jam (!692) · Merge requests · GStreamer / gstreamer-rs · GitLab

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

Sebastian Dröge requested to merge slomo/gstreamer-rs:videotimecode-try-from-copy into master Feb 03, 2021

As ffi::GstVideoTimeCode implements Copy, assignments don't move it out
of the passed in value but just copy it. This doesn't increase the
reference count of the daily jam, still runs the Drop impl of the passed
in value to decrease the daily jam and then causes a second unref of it
later when the returned value is dropped.

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/-/issues/310