Skip to content

video/time_code_interval: Do not compare minutes to hours in PartialEq

Marijn Suijten requested to merge MarijnS95/gstreamer-rs:fix-broken-match into master

Clippy nightly is becoming surprisingly smart these days:

warning: This sequence of operators looks suspiciously like a bug.
  --> gstreamer-video/src/video_time_code_interval.rs:66:16
   |
66 |             && self.0.minutes == other.0.hours
   |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: I think you meant: `self.0.minutes == other.0.minutes`
   |
   = note: `#[warn(clippy::suspicious_operation_groupings)]` on by default
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_operation_groupings

Since GstVideoTimeCodeInterval is a plain old datatype, shouldn't gir simply generate derive(PartialEq, Eq) on it?

Merge request reports