Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gst-rtsp-server gst-rtsp-server
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 94
    • Issues 94
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 8
    • Merge requests 8
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GStreamerGStreamer
  • gst-rtsp-servergst-rtsp-server
  • Merge requests
  • !3

rtsp-stream: Use seqnum-offset for rtpinfo

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Linus Svensson requested to merge linussn/gst-rtsp-server:master into master Nov 09, 2018
  • Overview 7
  • Commits 2
  • Pipelines 1
  • Changes 1

The RTP sequence number in the rtpinfo should be the first sequence number that the client can expect from the RTSP server. The current value is fetched 1) reading the last sample on the sink element, or 2) read the "stats" property on the payloader (in case it is present) and 3) the seqnum property from the payloader.

The seqnum property on the payloader is currently not correct if a buffer list was pushed. It should reflect the sequence number of the last pushed buffer, but for a list it will be the first buffer from the list. It should be the last buffer. If that is fixed, the rtpinfo will not be generated correctly anymore.

To prepare gst-rtsp-server for a seqnum property fix, it is changed to read the "seqnum-offset" from the "stats" property. If there are no "stats" property seqnum is still read.

Edited Nov 09, 2018 by Sebastian Dröge
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master