Skip to content

Backport of "rtspclientsink: Set async-handling=false for the internal bins" into 1.16

Tim-Philipp Müller requested to merge tpm/gst-rtsp-server:backport-mr-31-into-1.16-client-sink-send-messages into 1.16

Part-Backport of !31 (merged) "rtspclientsink: Use write_messages() API to send buffer lists in one go".

Without this we can easily run into a race condition with async state changes:

  • the pipeline is doing an async state change
  • we set the internal bins to PLAYING but that's ignored because an async state change is currently pending
  • the async state change finishes but does not change the state of the internal bins because of locked_state==TRUE
  • the internal bins stay in PAUSED forever

Commits:

  • 640c5bba rtspclientsink: Set async-handling=false for the internal bins
Edited by Tim-Philipp Müller

Merge request reports