Skip to content
Snippets Groups Projects

rtsp-media: do not unblock on unsuspend

Merged Mathieu Duponchelle requested to merge meh/gst-rtsp-server:media-fix-unsuspend into master
  1. Sep 08, 2020
    • Mathieu Duponchelle's avatar
      rtsp-media: do not unblock on unsuspend · 883ddc72
      Mathieu Duponchelle authored and GStreamer Marge Bot's avatar GStreamer Marge Bot committed
      rtsp_media_unsuspend() is called from handle_play_request()
      before sending the play response. Unblocking the streams here
      was causing data to be sent out before the client was ready
      to handle it, with obvious side effects such as initial packets
      getting discarded, causing decoding errors.
      
      Instead we can simply let the media streams be unblocked when
      the state of the media is set to PLAYING, which occurs after
      sending the play response.
      
      Part-of: <!147>
      883ddc72
Loading