Skip to content
Snippets Groups Projects

amrnbenc: remove global variables

Merged Jordan Petridіs requested to merge alatiera/gst-plugins-ugly:alatiera/fedora-32-2 into master
All threads resolved!

gstcheck is declaring its own buffers glist which ends up overwritten, loks like the code meant to use that already

gcc 10 is also complaining about this, but only on static builds for some reason

FAILED: subprojects/gst-plugins-ugly/tests/check/elements_amrnbenc
/usr/bin/ld: subprojects/gstreamer/libs/gst/check/libgstcheck-1.0.a(gstcheck.c.o):(.bss+0x38): multiple definition of `buffers'; subprojects/gst-plugins-ugly/tests/check/708af1f@@elements_amrnbenc@exe/elements_amrnbenc.c.o:(.bss+0x18): first defined here
collect2: error: ld returned 1 exit status

also remove unused var current_buf

Edited by Jordan Petridіs

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 6caecef6 - amrnbenc: remove global variables

    Compare with previous version

  • Jordan Petridіs changed title from amrnbenc: namespace global variables to amrnbenc: remove global variables

    changed title from amrnbenc: namespace global variables to amrnbenc: remove global variables

  • Jordan Petridіs changed the description

    changed the description

  • Jordan Petridіs resolved all threads

    resolved all threads

  • added 1 commit

    • d7d05eb5 - amrnbenc: remove global variables

    Compare with previous version

  • added 11 commits

    Compare with previous version

  • assigned to @alatiera and unassigned @gstreamer-merge-bot

  • I couldn't merge this branch: CI failed!

  • assigned to @gstreamer-merge-bot and unassigned @alatiera

  • changed milestone to %1.17.90

  • Please register or sign in to reply
    Loading