README.md

@@ -12,7 +12,7 @@ API builds upon the [application-side GStreamer bindings](https://github.com/sdr
 Check the README.md of that repository also for details about how to set-up
 your development environment.
 
-Various example plugins can be found in the [GIT repository](https://github.com/sdroege/gst-plugin-rs/).
+Various example plugins can be found in the [GIT repository](https://github.com/sdroege/gst-plugin-rs/). A blog post series about writing GStreamer plugins/elements can be found [here](https://coaxion.net/blog/2018/01/how-to-write-gstreamer-elements-in-rust-part-1-a-video-filter-for-converting-rgb-to-grayscale/).
 
 For background and motivation, see the [announcement
 blogpost](https://coaxion.net/blog/2016/05/writing-gstreamer-plugins-and-elements-in-rust/)

gst-plugin-audiofx/src/lib.rs

@@ -12,6 +12,7 @@ extern crate byte_slice_cast;
 extern crate glib;
 #[macro_use]
 extern crate gst_plugin;
+#[macro_use]
 extern crate gstreamer as gst;
 extern crate gstreamer_audio as gst_audio;
 extern crate gstreamer_base as gst_base;

gst-plugin/CHANGELOG.md

@@ -5,6 +5,11 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html),
 specifically the [variant used by Rust](http://doc.crates.io/manifest.html#the-version-field).
 
+## [0.1.4] - 2018-02-12
+### Fixed
+- Fix BaseSrc::unlock_stop() and the same in BaseSink. It was calling unlock()
+  instead of unlock_stop() before, making it rather useless.
+
 ## [0.1.3] - 2018-01-15
 ### Fixed
 - Only require GStreamer >= 1.8, not >= 1.10. We didn't use any 1.10 API

gst-plugin/Cargo.toml

 [package]
 name = "gst-plugin"
-version = "0.1.3"
+version = "0.1.4"
 authors = ["Sebastian Dröge <sebastian@centricular.com>"]
 categories = ["multimedia"]
 description = "Infrastructure for writing GStreamer plugins in Rust"

gst-plugin/README.md

@@ -12,7 +12,7 @@ API builds upon the [application-side GStreamer bindings](https://github.com/sdr
 Check the README.md of that repository also for details about how to set-up
 your development environment.
 
-Various example plugins can be found in the [GIT repository](https://github.com/sdroege/gst-plugin-rs/).
+Various example plugins can be found in the [GIT repository](https://github.com/sdroege/gst-plugin-rs/). A blog post series about writing GStreamer plugins/elements can be found [here](https://coaxion.net/blog/2018/01/how-to-write-gstreamer-elements-in-rust-part-1-a-video-filter-for-converting-rgb-to-grayscale/).
 
 For background and motivation, see the [announcement
 blogpost](https://coaxion.net/blog/2016/05/writing-gstreamer-plugins-and-elements-in-rust/)

gst-plugin/src/base_sink.rs

@@ -267,7 +267,7 @@ macro_rules! box_base_sink_impl(
 
             fn unlock_stop(&self, element: &T) -> bool {
                 let imp: &$name<T> = self.as_ref();
-                imp.unlock(element)
+                imp.unlock_stop(element)
             }
         }
     };

gst-plugin/src/base_src.rs

@@ -339,7 +339,7 @@ macro_rules! box_base_src_impl(
 
             fn unlock_stop(&self, element: &T) -> bool {
                 let imp: &$name<T> = self.as_ref();
-                imp.unlock(element)
+                imp.unlock_stop(element)
             }
         }
     };

gst-plugin/src/plugin.rs

@@ -40,7 +40,24 @@ macro_rules! plugin_define(
             });
 
             unsafe extern "C" fn plugin_init_trampoline(plugin: *mut $crate::gst_ffi::GstPlugin) -> $crate::glib_ffi::gboolean {
-                super::$plugin_init(&from_glib_borrow(plugin)).to_glib()
+                use std::panic::{self, AssertUnwindSafe};
+
+                let result = panic::catch_unwind(AssertUnwindSafe(|| super::$plugin_init(&from_glib_borrow(plugin)).to_glib()));
+                match result {
+                    Ok(result) => result,
+                    Err(err) => {
+                        let cat = $crate::gst::DebugCategory::get("GST_PLUGIN_LOADING").unwrap();
+                        if let Some(cause) = err.downcast_ref::<&str>() {
+                            gst_error!(cat, "Failed to initialize plugin due to panic: {}", cause);
+                        } else if let Some(cause) = err.downcast_ref::<String>() {
+                            gst_error!(cat, "Failed to initialize plugin due to panic: {}", cause);
+                        } else {
+                            gst_error!(cat, "Failed to initialize plugin due to panic");
+                        }
+
+                        $crate::glib_ffi::GFALSE
+                    }
+                }
             }
         }
     };