Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gst-plugins-rs gst-plugins-rs
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 68
    • Issues 68
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 23
    • Merge requests 23
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GStreamer
  • gst-plugins-rsgst-plugins-rs
  • Merge requests
  • !650

Open
Created Jan 20, 2022 by Antonio Larrosa@antlarr
  • Report abuse
Report abuse

Add a dependency check for libwebp

  • Overview 0
  • Commits 3
  • Pipelines 4
  • Changes 3

Otherwise the built libgstrswebp.so plugin is built but it doesn't link against libwebp . This result in symbols being left undefined in libgstrswebp.so .

This can be checked by building gst-plugins-rs without libwebp devel files installed in the system. Then running gst-inspect-1.0 gives:

(gst-plugin-scanner-x86_64:31702): GStreamer-WARNING **: 11:41:01.778: Failed to load plugin '/usr/lib64/gstreamer-1.0/libgstrswebp.so': /usr/lib64/gstreamer-1.0/libgstrswebp.so: undefined symbol: WebPAnimDecoderDelete

Running ldd /usr/lib64/gstreamer-1.0/libgstrswebp.so shows that the webp plugin doesn't even try to link with the libwebp library.

This MR fixes that by failing the build when libwebp is not available (and is not disabled using the command line).

Edited Jan 20, 2022 by Antonio Larrosa
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: add-libwep-dep