Skip to content

webrtcsink: don't panic with bitrate handling unsupported encoders

When an encoder was not supported by the VideoEncoder bitrate accessors, an unimplemented panic would occur which would poison state & settings Mutexs resulting in other threads panicking, notably entering end_session(), which lead to many failures in BinImplExt::parent_remove_element() until a segmentation fault ended the process. This was observed using vaapivp9enc.

This commit logs a warning if an encoder isn't supported by the bitrate accessors and silently by-passes bitrate-related operations when unsupported.

Merge request reports