gst: don't use volatile to mean atomic (!911) · Merge requests · GStreamer / gst-plugins-good · GitLab

Snippets Groups Projects

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

The migration is almost done, at least the rest should happen in the background. There are still a few technical difference between the old cluster and the new ones, and they are summarized in this issue. Please pay attention to the TL:DR at the end of the comment.

Merged Matthew Waters requested to merge ystreet/gst-plugins-good:gst-good-drop-volatile into master 4 years ago

volatile is not sufficient to provide atomic guarantees and real atomics should be used instead. GCC 11 has started warning about using volatile with atomic operations.

https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1719

Discovered in #868 (closed)

Activity

Matthew Waters assigned to @gstreamer-merge-bot 4 years ago

assigned to @gstreamer-merge-bot
Matthew Waters mentioned in commit ystreet/gst-plugins-good@612102fd 4 years ago

mentioned in commit ystreet/gst-plugins-good@612102fd
GStreamer Marge Bot added 1 commit 4 years ago
added 1 commit

612102fd - gst: don't use volatile to mean atomic

Compare with previous version
GStreamer Marge Bot merged 4 years ago

merged
Tim-Philipp Müller added 1.18 Needs backport labels 3 years ago

added 1.18 Needs backport labels
Tim-Philipp Müller added Backported into 1.18 label and removed Needs backport label 3 years ago

added Backported into 1.18 label and removed Needs backport label
Tim-Philipp Müller @tpm · 3 years ago

Owner

Merge Request for backport into 1.18 branch: !941 (merged) (target milestone: 1.18.5)

Needs manual intervention!
Tim-Philipp Müller mentioned in merge request !941 (merged) 3 years ago

mentioned in merge request !941 (merged)
Matthew Waters mentioned in commit tpm/gst-plugins-good@4b4f8c08 3 years ago

mentioned in commit tpm/gst-plugins-good@4b4f8c08
GStreamer Release Monkey changed milestone to %1.19.1 3 years ago

changed milestone to %1.19.1
Matthew Waters mentioned in commit ocrete/gst-plugins-good@536e0159 3 years ago

mentioned in commit ocrete/gst-plugins-good@536e0159
Olivier Crête mentioned in merge request !1012 (merged) 3 years ago

mentioned in merge request !1012 (merged)
Olivier Crête added Backported into 1.16 label 3 years ago

added Backported into 1.16 label
Olivier Crête added 1.16 label 3 years ago

added 1.16 label

Please register or sign in to reply