wavpackdec: Add floating point format support

This commit negotiate F32 audio format if MODE_FLOAT used in wavpack file. Wavpack float mode is always in 32-bit IEEE format.

The following pipeline plays distorted audio if source file is encoded in float mode: gst-launch-1.0 filesrc ... ! wavpackparse ! wavpackdec ! pulsesink

I'm not sure what branch should I target, I have 1.16 in Gentoo, but it could be merged in master as well. Please advice.

Thanks for the patch!

Please target master. We then decide whether to backport things once it's been merged into master.

changed target branch from 1.16 to master

added 876 commits

• ac1ba62c...e73559f8 - 875 commits from branch gstreamer:master
• 8112fc97 - Add floating point format support for wavpack decoder

Compare with previous version

Done, thanks.

changed title from Add floating point format support for wavpack decoder to wavpackdec: Add floating point format support

Thanks! Could you also update the commit message summary to wavpackdec: Add floating point format support or somesuch please? (ie element name first)

Got it, thanks!

So what you want me to do:

1. expose mode bits as-is in parser's caps.
2. instead of getting bits from GetMode, get them from parser caps.
3. negotiate decoder audio format as is now. Right?

No, what I meant for the parser would be completely independent of the decoder and can also be done in a separate MR. The changes here are fine as they are.

resolved all threads

Right, and the parser has no dependency on wavpack library, right? I see, I'll try to add it there too, but it may require a bit more effort Thanks

It doesn't, but it already parses that field IIRC so it should just be a matter of putting it into the caps :) Thanks for looking into that!

added 1 commit

• a25ee2e1 - wavpackdec: Add floating point format support

Compare with previous version

resolved all threads

assigned to @gstreamer-merge-bot

mentioned in commit whoozle/gst-plugins-good@94b55a93

added 1 commit

• 94b55a93 - wavpackdec: Add floating point format support

Compare with previous version

mentioned in commit whoozle/gst-plugins-good@4de3ddad

added 1 commit

• 4de3ddad - wavpackdec: Add floating point format support

Compare with previous version