Skip to content
Snippets Groups Projects

wavpackdec: Add floating point format support

Merged Vladimir Menshakov requested to merge whoozle/gst-plugins-good:fix-wavpack-f32 into master

This commit negotiate F32 audio format if MODE_FLOAT used in wavpack file. Wavpack float mode is always in 32-bit IEEE format.

The following pipeline plays distorted audio if source file is encoded in float mode: gst-launch-1.0 filesrc ... ! wavpackparse ! wavpackdec ! pulsesink

Edited by Tim-Philipp Müller

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Got it, thanks!

    So what you want me to do:

    1. expose mode bits as-is in parser's caps.
    2. instead of getting bits from GetMode, get them from parser caps.
    3. negotiate decoder audio format as is now. Right?
  • No, what I meant for the parser would be completely independent of the decoder and can also be done in a separate MR. The changes here are fine as they are.

  • Vladimir Menshakov resolved all threads

    resolved all threads

  • Right, and the parser has no dependency on wavpack library, right? I see, I'll try to add it there too, but it may require a bit more effort :sweat_smile: Thanks

  • It doesn't, but it already parses that field IIRC so it should just be a matter of putting it into the caps :) Thanks for looking into that!

  • added 1 commit

    • a25ee2e1 - wavpackdec: Add floating point format support

    Compare with previous version

  • Sebastian Dröge resolved all threads

    resolved all threads

  • added 1 commit

    • 94b55a93 - wavpackdec: Add floating point format support

    Compare with previous version

  • added 1 commit

    • 4de3ddad - wavpackdec: Add floating point format support

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading