Skip to content
Snippets Groups Projects

deinterlace: Better alternate support

Merged Vivia Nikolaidou requested to merge vivia/gst-plugins-good:deinterlate_alternate into master

Improve TFF/BFF autodetection according to first frame after a segment, instead of letting it continuously switch between TFF and BFF. Results in smoother transitions. Also handle the buffer state the same as mixed.

Edited by Vivia Nikolaidou

Merge request reports

Merge request pipeline #265566 passed

Merge request pipeline passed for 25f98ab1

Merged by Vivia NikolaidouVivia Nikolaidou 4 years ago (Feb 3, 2021 3:46pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Vivia Nikolaidou added 3 commits

    added 3 commits

    • 43c5cc49 - deinterlace: Better alternate support
    • e8a73b6c - deinterlace: Fix telecine/onefield mixup
    • 200ca892 - deinterlace: Provide documentation for GST_DEINTERLACE_BUFFER_STATE

    Compare with previous version

  • Vivia Nikolaidou resolved all threads

    resolved all threads

  • Author Maintainer

    Still getting combs in this test case: gst-launch-1.0 videotestsrc pattern=ball ! video/x-raw,interlace-mode=progressive ! queue ! interlace field-pattern=0 top-field-first=true ! video/x-raw\(format:Interlaced\),interlace-mode=alternate ! queue ! deinterlace ! queue ! autovideosink

    but not with interlace top-field-first=false, and also not with two test files that I have (one TFF which I can't make public, and one in https://trac.ffmpeg.org/ticket/5514)

  • mentioned in merge request gst-plugins-bad!1996 (merged)

  • Vivia Nikolaidou added 5 commits

    added 5 commits

    • 200ca892...5f00810e - 2 commits from branch gstreamer:master
    • 132390c0 - deinterlace: Better alternate support
    • 78049963 - deinterlace: Fix telecine/onefield mixup
    • e786c973 - deinterlace: Provide documentation for GST_DEINTERLACE_BUFFER_STATE

    Compare with previous version

  • Vivia Nikolaidou resolved all threads

    resolved all threads

  • Vivia Nikolaidou resolved all threads

    resolved all threads

  • Vivia Nikolaidou added 3 commits

    added 3 commits

    • 77a0ac97 - deinterlace: Better alternate support
    • 873e7aab - deinterlace: Fix telecine/onefield mixup
    • c26ed317 - deinterlace: Provide documentation for GST_DEINTERLACE_BUFFER_STATE

    Compare with previous version

  • Jan Alexander Steffens
  • LGTM! 👍

  • Jan Alexander Steffens approved this merge request

    approved this merge request

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading