Skip to content
Snippets Groups Projects

rtspsrc: Use URI hash for stream id

Merged Chris Duncan requested to merge ChrisDuncan/gst-plugins-good:fix-rtspsrc-stream-id into master

rtspsrc currently extracts an upstream stream-id and appends some session description meta. When upstream elements like udpsrc generate a random id, sometimes they are not unique. This causes issues in muxing/demuxing in funnel/streamiddemux.

This MR proposes a change in which the upstream id is ignored and the new generated stream-id consists of a RTSP URI hash and the appended SDP meta.

Edited by Chris Duncan

Merge request reports

Merge request pipeline #226993 passed

Merge request pipeline passed for d9ea3346

Merged by GStreamer Marge BotGStreamer Marge Bot 4 years ago (Nov 11, 2020 7:51am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sebastian Dröge
  • Looks good to me otherwise, thanks!

  • Chris Duncan added 2 commits

    added 2 commits

    • 2ce4c172 - Use consistent URI hashed stream-id for UDP and TCP/Interleaved streams
    • 583c125b - rtspsrc: ensure same group-id used for both TCP/UDP stream-start events

    Compare with previous version

  • Chris Duncan added 2 commits

    added 2 commits

    • 572c973c - rtspsrc: Use consistent URI hashed stream-id for UDP and TCP/Interleaved streams
    • e42e437e - rtspsrc: ensure same group-id used for both TCP/UDP stream-start events

    Compare with previous version

  • Chris Duncan added 1 commit

    added 1 commit

    • 99348c07 - rtspsrc: Ensure same group-id used for both TCP/UDP stream-start events

    Compare with previous version

  • Sebastian Dröge resolved all threads

    resolved all threads

  • Sebastian Dröge
  • Chris Duncan added 1 commit

    added 1 commit

    • ae502f11 - rtspsrc: ensure same group-id used for both TCP/UDP stream-start events

    Compare with previous version

  • Chris Duncan resolved all threads

    resolved all threads

  • Chris Duncan added 1 commit

    added 1 commit

    • 910d7e9b - rtspsrc: Ensure same group-id used for both TCP/UDP stream-start events

    Compare with previous version

  • added 2 commits

    • e5f5e712 - rtspsrc: Use consistent URI hashed stream-id for UDP and TCP/Interleaved streams
    • 9d2ae2c9 - rtspsrc: Ensure same group-id used for both TCP/UDP stream-start events

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading