vp8enc: extend support for temporal scalability, implement payloading support (!728) · Merge requests · GStreamer / gst-plugins-good · GitLab

Snippets Groups Projects

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

The migration is almost done, at least the rest should happen in the background. There are still a few technical difference between the old cluster and the new ones, and they are summarized in this issue. Please pay attention to the TL:DR at the end of the comment.

Merged Mathieu Duponchelle requested to merge meh/gst-plugins-good:vp8-temporal-scalability into master 4 years ago

Patches extracted from Pexip's gst-plugins-good branch.

For now, I have only extracted that set of patches, made it build on its own, ported to the future custom meta API (gstreamer!609 (merged)), made tests pass and modified a few things I spotted while doing so, but I still haven't given it an in-depth review.

From what I see the code looks sound and the mechanism to transport information from the encoder to the payloader makes sense to me, there are also quite a few unit tests, which is good. What I want to review in more detail is the payloading code wrt the RFC (https://tools.ietf.org/html/rfc7741#section-4.2), once I have done that I'll unWIP this.

Edited 4 years ago by Mathieu Duponchelle

Activity

Tim-Philipp Müller changed title from WIP: extend support for temporal scalability in vp8enc, implement payloading support to WIP: vp8enc,: extend support for temporal scalability, implement payloading support 4 years ago

changed title from WIP: extend support for temporal scalability in vp8enc, implement payloading support to WIP: vp8enc,: extend support for temporal scalability, implement payloading support
Tim-Philipp Müller changed title from WIP: vp8enc,: extend support for temporal scalability, implement payloading support to WIP: vp8enc: extend support for temporal scalability, implement payloading support 4 years ago

changed title from WIP: vp8enc,: extend support for temporal scalability, implement payloading support to WIP: vp8enc: extend support for temporal scalability, implement payloading support
Mathieu Duponchelle @meh started a thread on an old version of the diff 4 years ago

Resolved 4 years ago by Mathieu Duponchelle
Last reply by Mathieu Duponchelle 4 years ago

Mathieu Duponchelle @meh started a thread on an old version of the diff 4 years ago

Resolved 4 years ago by Mathieu Duponchelle

Mathieu Duponchelle @meh started a thread on the diff 4 years ago

Resolved 4 years ago by Mathieu Duponchelle

Mathieu Duponchelle @meh started a thread on the diff 4 years ago

Resolved 4 years ago by Mathieu Duponchelle

Mathieu Duponchelle @meh started a thread on an old version of the diff 4 years ago

Resolved 4 years ago by Mathieu Duponchelle

Mathieu Duponchelle @meh started a thread on an old version of the diff 4 years ago

Resolved 4 years ago by Mathieu Duponchelle

Mathieu Duponchelle @meh started a thread on an old version of the diff 4 years ago

Resolved 4 years ago by Mathieu Duponchelle

Mathieu Duponchelle @meh · 4 years ago

Author Maintainer

The extended payloading code matches the RFC as expected, good :) Addressing my own review comments and un WIPing now

Mathieu Duponchelle @meh started a thread on the diff 4 years ago

Resolved 4 years ago by Mathieu Duponchelle

Mathieu Duponchelle resolved all threads 4 years ago

resolved all threads

Mathieu Duponchelle added 5 commits 4 years ago

added 5 commits

3ba689ba - vp8enc: finish support for temporally scaled encoding
0b91978d - vp8enc: expect bps for temporal-scalability-target-bitrate.
d3dbc487 - rtpvp8pay: move duplicate code to separate functions
25638387 - rtpvp8pay: Add picture-id-offset property
ec87e6ee - rtpvp8pay: payload temporally scaled bitstreams.

Compare with previous version

Toggle commit list

Mathieu Duponchelle unmarked as a Work In Progress 4 years ago

unmarked as a Work In Progress

Mathieu Duponchelle added 32 commits 4 years ago

added 32 commits

ec87e6ee...a73ede42 - 27 commits from branch gstreamer:master
da2352eb - vp8enc: finish support for temporally scaled encoding
96ce85df - vp8enc: expect bps for temporal-scalability-target-bitrate.
d0cbc718 - rtpvp8pay: move duplicate code to separate functions
4aebddaf - rtpvp8pay: Add picture-id-offset property
0732e724 - rtpvp8pay: payload temporally scaled bitstreams.

Compare with previous version

Toggle commit list

Mathieu Duponchelle added 5 commits 4 years ago

added 5 commits

4e80622a - vp8enc: finish support for temporally scaled encoding
30bc90f3 - vp8enc: expect bps for temporal-scalability-target-bitrate.
b0de0a21 - rtpvp8pay: move duplicate code to separate functions
731ae7d4 - rtpvp8pay: Add picture-id-offset property
facfe1c2 - rtpvp8pay: payload temporally scaled bitstreams.

Compare with previous version

Toggle commit list

Mathieu Duponchelle added 5 commits 4 years ago

added 5 commits

9e70a6b6 - vp8enc: finish support for temporally scaled encoding
6ec548b6 - vp8enc: expect bps for temporal-scalability-target-bitrate.
e7c53f7f - rtpvp8pay: move duplicate code to separate functions
063acffa - rtpvp8pay: Add picture-id-offset property
3f59b5be - rtpvp8pay: payload temporally scaled bitstreams.

Compare with previous version

Toggle commit list

Mathieu Duponchelle added 5 commits 4 years ago

added 5 commits

dac5017c - vp8enc: finish support for temporally scaled encoding
327dcf2e - vp8enc: expect bps for temporal-scalability-target-bitrate.
3e618dce - rtpvp8pay: move duplicate code to separate functions
05b11eab - rtpvp8pay: Add picture-id-offset property
8d53752b - rtpvp8pay: payload temporally scaled bitstreams.

Compare with previous version

Toggle commit list

Tim-Philipp Müller approved this merge request 4 years ago

approved this merge request

Tim-Philipp Müller added label 4 years ago

added Enhancement label

Please register or sign in to reply