Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
gst-plugins-good
gst-plugins-good
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 620
    • Issues 620
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 110
    • Merge Requests 110
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GStreamer
  • gst-plugins-goodgst-plugins-good
  • Merge Requests
  • !710

Merged
Opened Aug 31, 2020 by Jan Alexander Steffens@heftigDeveloper

flvmux: Correct breaks in gst_flv_mux_find_best_pad

  • Overview 1
  • Commits 1
  • Pipelines 2
  • Changes 1

The code seems to use continue and break as if both refer to the surrounding while loop. But because break breaks out of the switch, they actually have the same effect.

This may have caused the loop not to terminate when it should. E.g. when skip_backwards_streams drops a buffer we should abort the aggregation and wait for all pads to be filled again. Instead, we might have just selected a subsequent pad as our new "best".

Replace break with done = TRUE; break, and continue with break. Then simplify the code a bit.

Assignee
Assign to
Reviewer
Request review from
1.18.0
Milestone
1.18.0 (Past due)
Assign milestone
Time tracking
Reference: gstreamer/gst-plugins-good!710
Source branch: flvmux-best-pad-break