Skip to content

souphttpsrc: don't fail when seeking past the end of the content

Michael Olbrich requested to merge mol/gst-plugins-good:soup into master

souphttpsrc produces an GST_ELEMENT_ERROR instead of an EOS event when seeking past the end of the file.

It's a bit tricky to reproduce, but I've managed with this test-case:

gst-validate-1.0 --set-scenario soup.scenario playbin ring-buffer-max-size=100000000  buffer-size=8000000 uri= http://ftp.halifax.rwth-aachen.de/blender/demo/movies/ToS/tears_of_steel_720p.mov

with the following scenario:

description, seek=true
seek, playback-time=1.0, rate=1.0, start=730.0, flags=flush
seek, playback-time=733.0, rate=1.0, start=307.0, flags=flush
seek, playback-time=309.0, rate=1.0, start=730.0, flags=flush

I'm pretty sure the seek event from queue2 is correct: It does not know, that the file ends there. Maybe souphttpsrc could skip the request completely instead, but I'm not sure how reliable the content size is. So I choose to handle the resulting error response instead.

Merge request reports