Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
gst-plugins-good
gst-plugins-good
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 621
    • Issues 621
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 110
    • Merge Requests 110
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GStreamer
  • gst-plugins-goodgst-plugins-good
  • Merge Requests
  • !359

Merged
Opened Sep 27, 2019 by Olivier Crête@ocrete👻Maintainer

rtpjitterbuffer: Cancel timers instead of just unlocking loop thread

  • Overview 2
  • Commits 1
  • Pipelines 3
  • Changes 2

When the queue is full (and adding more packets would risk a seqnum roll-over), the best approach is to just start pushing out packets from the other side. Just pushing out the packets results in the timers being left hanging with old seqnums, so it's safer to just execute them immediately in this case. It does limit the timer space to the time it takes to receiver about 32k packets, but without extended sequence number, this is the best RTP can do.

This also results in the test no longer needed to have timeouts or timers as pushing packets in drives everything.

Note that this strictly depends on !252 (merged), I think in the 1.16 branch, I'll suggest just removing that unit test.

Fixes #619 (closed)

Assignee
Assign to
Reviewer
Request review from
1.17.1
Milestone
1.17.1 (Past due)
Assign milestone
Time tracking
Reference: gstreamer/gst-plugins-good!359
Source branch: 619-fix-flaky-jitterbuffer-queue-filling-test