Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gst-plugins-good gst-plugins-good
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 647
    • Issues 647
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 82
    • Merge requests 82
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GStreamer
  • gst-plugins-goodgst-plugins-good
  • Merge requests
  • !25

v4l2: Properly fix Android build

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nicolas Dufresne requested to merge ndufresne/gst-plugins-good:android-build into master Nov 21, 2018
  • Overview 1
  • Commits 1
  • Pipelines 4
  • Changes 1

The previous patch did not even compile on any possible platform or C standard. That commit also didn't have a proper commit message.

Android ships Linux with a different signature for ioctl. They first released an ioctl with int as request type, and later "fixed" it by adding an override with unsign, which is still not matching Linux and BSD implementation which uses unsigned long int.

Fixes !24 (merged)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: android-build