Skip to content

splitmuxsink: Prevent hang going back to NULL after failures

Jan Schmidt requested to merge thaytan/gst-plugins-good:splitmuxsink-handle-failures into master

Prevent a condition where splitmuxsink won't go back to NULL state after a child element fails to change state by making sure that a READY->READY state change doesn't fail, and by returning GST_FLOW_ERROR or GST_FLOW_FLUSHING upstream to shut down streaming as quickly as possible.

This can happen after (for example) setting an invalid filename on the sink element. In that case, the READY->PAUSED transition fails, but with internal elements still in the NULL state. Trying to set splitmuxsink back to NULL then ends up trying to bring those NULL elements up to READY with a READY->READY transition, (which fails, prevent splitmuxsink from getting to NULL)

Merge request reports