videoflip: caps are not properly renegotiated when changing the method to GST_VIDEO_ORIENTATION_IDENTITY
I have an application that changes the flip method at runtime with a tag event.
When the method is changed to GST_VIDEO_ORIENTATION_IDENTITY
then the caps are not correctly renegotiated.
I think, this is caused by !836 (merged). The problem is, that in this case, the element is set into passthrough mode. As a result, gst_video_flip_transform_frame
is no longer called and change_configuring_method
is never set to TRUE
. So gst_video_flip_transform_caps()
continues to use the old method.
The result is, that I see a 2160x3840 resolution in the caps but a buffer with 3840x2160 at the sink.
I'm not sure how this should be fixed. From what I understand, we can set change_configuring_method
in gst_video_flip_set_method()
. I think that would work when it is called from a tag event, but not from the property. Or am I missing something here?