Skip to content

GitLab

gst-plugins-good
gst-plugins-good
Open
Opened by Florent Thiery@florent.thiery

mp4mux reserved-max-duration property should not accept value 0

mp4mux's property documentation states that value 0 is accepted:

  reserved-max-duration: When set to a value > 0, reserves space for index tables at the beginning of the file.
                        flags: accès en lecture, accès en écriture
                        Unsigned Integer64. Range: 0 - 18446744073709551615 Default: 18446744073709551615

However:

$ gst-launch-1.0 videotestsrc is-live=true ! x264enc tune=zerolatency ! mp4mux reserved-max-duration=0 reserved-moov-update-period=30000000000 ! filesink location=/tmp/test.mp4
...
ERROR: from element /GstPipeline:pipeline0/GstMP4Mux:mp4mux0: reserved-max-duration of 0 is not allowed
Additional debug info:
../subprojects/gst-plugins-good/gst/isomp4/gstqtmux.c(3052): gst_qt_mux_start_file (): /GstPipeline:pipeline0/GstMP4Mux:mp4mux0

As a workaround, i used the value -1

$ LANG=C gst-launch-1.0 videotestsrc is-live=true ! x264enc tune=zerolatency ! mp4mux reserved-max-duration=-1 reserved-moov-update-period=30000000000 ! filesink location=/tmp/test.mp4

Why is 0 even in the accepted range ? Should the documentation not state When set to a value >= 0 ?

Edited by Florent Thiery