Skip to content
  • Alicia Boya García's avatar
    qtdemux: Fix race on pad reconnection · 8dd42666
    Alicia Boya García authored and Thibault Saunier's avatar Thibault Saunier committed
    Elements emitting frames through several srcpads should use a
    flow combiner to aggregate the chain returns and therefore only return
    GST_FLOW_NOT_LINKED to upstream when all the downstream pads have
    received GST_FLOW_NOT_LINKED.
    
    In addition to that, in order to handle pads being relinked downstream,
    the flow combiner should be reset in response to RECONFIGURE events.
    This ensures that a both srcpads process a chain operation before a
    GST_FLOW_NOT_LINKED can be propagated upstream (which would usually stop
    the pipeline).
    
    Otherwise, in a configuration with two srcpads, only one linked at a
    time, after the relink the element could chain data through the now
    unlinked pad and the flow combiner would resolve as GST_FLOW_NOT_LINKED
    (stopping the pipeline) just because the now linked pad has not been
    chained yet to update the flow combiner.
    
    This patch adds handling of RECONFIGURE events to qtdemux. Also, since
    this event handling causes the flow combiner to be used from a thread
    other than the qtdemux streaming thread, usages of the flow combiner
    has been guarded by the object lock.
    8dd42666