Skip to content

videoaggregator: Pop out old buffers on timeout

Edward Hervey requested to merge bilboed/gst-plugins-base:videoagg-late into master

This situation happens in the situation where an input stream has a framerate exceeding the timeout latency (Ex: 1fps with a latency of 500ms) and an input stream greater than output framerate (ex: 60fps in, 30 fps out).

The problem that would happen is that we would timeout, but then buffers from the fast input stream would only be popped out one by one.... until a buffer reaches the low-framerate input stream at which point they would quickly be popped out/used. The resulting output would be "slow ... fast ... slow ... fast" of that input fast stream.

In order to avoid this situation, whenever we detect a late buffer, check if there's a next one and re-check with that one.

Merge request reports