opus: add subproject fallback
Merge request reports
Activity
- Resolved by Tim-Philipp Müller
This is not needed anymore with recent meson though :-)
I think it depends on how we want it to behave, no?
From the meson docs:
Optional dependencies, like dependency('foo-1.0', required: get_option('foo_opt')) where foo_opt is a feature option set to auto, will not fallback to the subproject defined in the wrap file, for 2 reasons: (snip)
If it is desired to fallback for an optional dependency, the fallback or allow_fallback keyword arguments must be passed explicitly. Since 0.56.0, dependency('foo-1.0', required: get_option('foo_opt'), allow_fallback: true) will use the fallback even when foo_opt is set to auto. On version 0.55.0 the same effect could be achieved with dependency('foo-1.0', required: get_option('foo_opt'), fallback: 'foo').
However, for now our meson req is 0.54, though I expect that we bump it to latest sooner or later, but we need at least a 0.56.1 for that to fix the msvc
c_std
version issue.So I think we'll just leave it as in the patch and then we can clean up the wrap use later once we bumped the req to 0.56.
assigned to @gstreamer-merge-bot
mentioned in commit tpm/gst-plugins-base@78ccc551
added 6 commits
-
f58cae1b...fe20cac1 - 5 commits from branch
gstreamer:master
- 78ccc551 - opus: add subproject fallback
-
f58cae1b...fe20cac1 - 5 commits from branch
changed milestone to %1.19.1