Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
gst-plugins-base
gst-plugins-base
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 631
    • Issues 631
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 102
    • Merge Requests 102
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GStreamer
  • gst-plugins-basegst-plugins-base
  • Merge Requests
  • !915

Merged
Opened Nov 03, 2020 by Jan Alexander Steffens@heftigDeveloper

videoaggregator: Fix locking around vagg->info

  • Overview 10
  • Commits 1
  • Pipelines 4
  • Changes 1

Take GST_OBJECT_LOCK when writing vagg->info, so that reading in subclasses is protected against races, as documented in the struct.

/*< public >*/
/* read-only, with OBJECT_LOCK */
GstVideoInfo                  info;

gst_video_aggregator_default_negotiated_src_caps should take the GST_VIDEO_AGGREGATOR_LOCK to avoid racing with gst_video_aggregator_reset called by gst_video_aggregator_release_pad of the last sinkpad. Otherwise it can happen that latency = gst_util_uint64_scale (... gets called with a zero framerate.

There doesn't seem to be any reason not to use the local info instead of vagg->info, so do that.

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: gstreamer/gst-plugins-base!915
Source branch: vagg-lock