Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gst-plugins-base gst-plugins-base
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 641
    • Issues 641
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 80
    • Merge requests 80
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GStreamerGStreamer
  • gst-plugins-basegst-plugins-base
  • Merge requests
  • !671

rtpbasepayload: fix sequence numbers after a flush

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Ludvig Rappe requested to merge ludvigr/gst-plugins-base:rtpbasepayload-Fix-sequence-numbers-after-SEGMENT-event into master May 27, 2020
  • Overview 22
  • Commits 1
  • Pipelines 14
  • Changes 2

After a flush, the sequence number of the first message sent should be seqnum_base, if seqnum_offset is set manually.

Without this change the first message sent after a flush could have the wrong sequence number. E.g. when using GST_RTSP_SUSPEND_MODE_RESET, the pipeline is PAUSED, a seqnum-offset is set, and the pipeline then goes to PLAYING with a different range header (resulting in a flushing seek). The reason for this is that payload prepares a buffer with the correct sequence number and after this the flushing seek starts, removing the buffer with the correct sequence number. Then the next buffer prepared will have the wrong sequence number.

Edited Oct 14, 2020 by Sebastian Dröge
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: rtpbasepayload-Fix-sequence-numbers-after-SEGMENT-event