Skip to content

videorate: Fixes and minor cleanups

Thibault Saunier requested to merge thiblahute/gst-plugins-base:videorate_fixes into master 
commit 225fffcb5523d88bc90b32bebb66d33291958533 (HEAD -> videorate_fixes, thiblahute/videorate_fixes)
Author: Thibault Saunier <tsaunier@igalia.com>
Date:   Mon May 25 16:59:53 2020 -0400

    videorate: Fix buffer selection logic in reverse playback
    
    Stop comparing all timestamps from buffers that are before the segment
    with the segment.stop and just compare with the actual end times
    comparing to segment.stop for all the buffers that where before
    the segment.stop. Expectations for `reverse.10_to_1fps.validatetest`
    have been fixed to take that into account and comparing the checksums
    of the sinkpad and srcpad expectations makes pretty clear how wrong
    that was.
    
    (we can see in the expectations that videotestsrc outputs an extra
    buffer with pts == segment.stop and this one is now properly dropped
    by videorate as bec7f4ad5ed4bb1abfb92db946e654338766562b aimed at
    doing)

commit 51f343ec559709f1839638151688b8d257e25d6f
Author: Thibault Saunier <tsaunier@igalia.com>
Date:   Mon May 25 16:29:15 2020 -0400

    videorate: Factor out a method for the`max-duplication-time` property
    
    Sensibly simplifying gst_video_rate_transform_ip

commit 5249b8ecacdd059d175f503052b9cddb6bdfeb29
Author: Thibault Saunier <tsaunier@igalia.com>
Date:   Mon May 25 14:48:04 2020 -0400

    videorate: Use CLOCK_TIME_IS_VALID instead of checking CLOCK_TIME_NONE
    
    Making it more consistency with the rest of the code.

commit c2372a0f2e21c5bca72ceec4285cfcea90edb949
Author: Thibault Saunier <tsaunier@igalia.com>
Date:   Mon May 25 14:33:54 2020 -0400

    videorate: Factor out a method to reset mode
    
    Working on simplifying gst_video_rate_transform_ip

commit a581c328f3cdb5a65eae22083caeb34f8054285e
Author: Thibault Saunier <tsaunier@igalia.com>
Date:   Mon May 25 12:31:32 2020 -0400

    videorate: Do not push an extra buffer on EOS when we are done pushing already
    
    There is no reason that when we have already pushed all the buffers in
    a segment we push a new one on EOS

Merge request reports