Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • gst-plugins-base gst-plugins-base
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 642
    • Issues 642
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 79
    • Merge requests 79
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • GStreamerGStreamer
  • gst-plugins-basegst-plugins-base
  • Merge requests
  • !535

decodebin3: Avoid duplicate streams

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Alicia Boya García requested to merge ntrrgc/gst-plugins-base:decodebin3-avoid-duplicate-streams into master Jan 07, 2020
  • Overview 4
  • Commits 1
  • Pipelines 1
  • Changes 1

Elements emitting stream collections do so by not only posting the GST_MESSAGE_STREAM_COLLECTION, but also then pushing a GST_EVENT_STREAM_COLLECTION through each srcpad.

The latter is how decodebin3 detects stream collections itself, as the GST_MESSAGE_STREAM_COLLECTION may be posted before the source element is added to the pipeline and therefore missed.

But it should be noted: when the source has two srcpads the stream collection event is received twice!

When decodebin3 receives several stream collections it reacts by creating a new one combining all the streams... But the code doing so did not take into account the case mentioned before, where both collections are actually the same and have the same streams. This patch fixes that.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: decodebin3-avoid-duplicate-streams