Skip to content

Fix up various defines

Tim-Philipp Müller requested to merge tpm/gst-plugins-base:clean-up-defines into master

commit 68a5fb3b:

pango: check if localtime_r is available
HAVE_LOCALTIME_R was used, but never defined.

commit 2431df08:

vorbis: drop unneeded check for vorbis_synthesis_restart()
This was added in 1.0.1 more than 16 years ago, I think we
can safely assume this is always present now. Also in tremor.

While at it, bump vorbis requirement to 1.3.1 from 2010.

commit d9827d55:

tests: playback: include stdlib.h unconditionally
Like we do elsewhere. And drop the check for the header.
Also remove some superfluous unistd.h includes.

commit e18401e3:

tests: oggmux: check vorbisenc + theoraenc availability at runtime
HAVE_VORBIS was used but never set, so only 3 out of 7 tests
actually ran. Drop now-unused HAVE_THEORA define.

commit 37812910:

multifdsink: remove defunct include guarded by unused HAVE_FIONREAD_IN_SYS_FILIO
The configure check for this went away in 2012 in commit cd3eee.

commit 5143cc72:

tests: gl-launch-lines: check for features at runtime
Instead of using HAVE_PNG and HAVE_JPEG defines.

commit dae6ed49:

tests: simple-launch-lines: remove use of unused HAVE_LIBVISUAL define
This is not set anywhere, and it's pretty clear the pipeline in
question has not been tested in a long time. Disable test with
a FIXME, test needs to be rewritten to not use real output devices.

commit a98966c7:

typefindfunctions: build gio xdgmime typefinder again
And add gio-typefinder option to disable it. HAVE_GIO
was never set, at least not in the Meson build.

commit 7623b3d7:

test: fix up HAVE_X11 / HAVE_X defines
Only HAVE_X was defined, while both HAVE_X11 and HAVE_X were used.

commit d755f87f:

xvimage: remove unused HAVE_XVIDEO define

commit 4c6eda24:

tests: actually define HAVE_VALGRIND
This stuff should probably be done differently, but
for now just define it like we used to.

Merge request reports