Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • gst-plugins-base gst-plugins-base
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 642
    • Issues 642
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 79
    • Merge requests 79
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • GStreamerGStreamer
  • gst-plugins-basegst-plugins-base
  • Merge requests
  • !437

{video,audio}decoder: don't raise an error in bus when no frames decoded

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Víctor Manuel Jáquez Leal requested to merge vjaquez/gst-plugins-base:dont-break-stream-no-audio into master Sep 21, 2019
  • Overview 13
  • Commits 1
  • Pipelines 4
  • Changes 2

There's a sample in Khronos WebGL conformance test which is a webm container that expresses two streams:

Topology:
  container: WebM
    audio: Vorbis
    video: VP8

Properties:
  Duration: 0:00:05.038000000
  Seekable: yes
  Live: no
  Tags: 
      container format: Matroska
      language code: en

Nonetheless, the audio stream contains zero frames.

This configuration makes the audio decoder to raise an error in the bus. Using playbin2 the stream cannot be played at all. With playbin3 the stream is played and the error is raised at the end.

These error raising in audio decoding was added as a equivalence with video decoder in bug 711094, but even the proposal was questioned by the author.

This MR proposes a change in the audio decoder from raising an error in the bus, to a warning.

Questions:

  1. Should be do the same in video decoding?
  2. Should we add all these Khronos and WPT media samples in the integration tests? (Cc: @thiblahute)
Edited Sep 24, 2021 by Tim-Philipp Müller
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: dont-break-stream-no-audio