Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • gst-plugins-base gst-plugins-base
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 642
    • Issues 642
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 79
    • Merge requests 79
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • GStreamerGStreamer
  • gst-plugins-basegst-plugins-base
  • Merge requests
  • !317

playsink: fix audio passthrough hang when set play rate

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Haihua Hu requested to merge JaredHu/gst-plugins-base:fix_passthrough_hang into master Jul 02, 2019
  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 1

when audio passthrough is enable, audio_filter will not been put into audiochain. When do reconfigure, playsink will remove previous audio chain as audio_filter is not match with chain->filter (should be NULL). Then playsink will remove audio chain and recreate. When remove, streamsynchroinizer will release its sinkpad, but sinkpad is in waiting all pad eos as audio is eos in fast forward 4X mode and hold stream lock, release pad will also try to lock this stream lock and cause hang. Need check whether chain->filter is valided first to avoid recreate audio chain

Edited Jul 02, 2019 by Haihua Hu
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix_passthrough_hang