Skip to content

id3tag: Correctly validate the year from v1 tags before passing to GstDateTime

Sebastian Dröge requested to merge slomo/gst-plugins-base:id3tag-v1-year-validation into master

By using strtoul(), invalid values will get mapped to MAXULONG and we would have to check errno. They won't get mapped to 0.

To solve this, use the signed g_ascii_strtoll(). This will map errors to 0 or G_MAXINT64 or G_MININT64, and the valid range for GstDateTime is > 0 and <= 9999 so we can directly check for this here.

Fixes gstreamer#384 (closed)

Merge request reports