Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
gst-plugins-base
gst-plugins-base
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 625
    • Issues 625
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 101
    • Merge Requests 101
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GStreamer
  • gst-plugins-basegst-plugins-base
  • Merge Requests
  • !180

Open
Opened Mar 26, 2019 by Philipp Wolfer@phw
  • Report abuse
Report abuse

Fix reading MusicBrainz disc ID according to MB spec

  • Overview 4
  • Commits 1
  • Pipelines 1
  • Changes 1

For ID3 GStreamer is reading (and writing) the MusicBranz disc ID from the non-standard TXXX:MusicBrainz DiscID frame, while MusicBrainz specifies and uses TXXX:MusicBrainz Disc Id.

This fixes at least the reading part by allowing both variations. IMHO we should also fix the writing part, but GStreamer itself seems to have set a precedence for this by using TXXX:MusicBrainz DiscID which then gets written by tools depending on GStreamer like e.g. SoundJuicer. Hence such files wildly exist now, which would be an argument to stick to what is currently done. Luckily not many tools actually do write disc ID tags at all

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: gstreamer/gst-plugins-base!180
Source branch: fix-reading-mb-discid