Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gst-plugins-base gst-plugins-base
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 642
    • Issues 642
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 81
    • Merge requests 81
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GStreamerGStreamer
  • gst-plugins-basegst-plugins-base
  • Merge requests
  • !1237

videodecoder: Fix unexpected SEGMENT event drop before sending GAP event

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Seungha Yang requested to merge seungha.yang/gst-plugins-base:vdec-event-drop into master Jul 31, 2021
  • Overview 5
  • Commits 1
  • Pipelines 3
  • Changes 2

In case that decoder received multiple frames without output, priv->current_frame_events would not hold any event object but it's been moved to GstVideoCodecFrame object so that it can be sent when corresponding frame is decoded. So if no frame was outputted before the GAP event, the oldest frame is likely holding SEGMENT event. To ensure SEGMENT -> GAP event ordering, baseclass should check/push pending events on the oldest pending frame.

Edited Aug 03, 2021 by Seungha Yang
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: vdec-event-drop