Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gst-plugins-base gst-plugins-base
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 644
    • Issues 644
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 88
    • Merge requests 88
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GStreamer
  • gst-plugins-basegst-plugins-base
  • Merge requests
  • !1088

xvimagesink: Handle cropping when copying frames.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Víctor Manuel Jáquez Leal requested to merge vjaquez/gst-plugins-base:xvimagesink-propose-allocation into master Mar 29, 2021
  • Overview 7
  • Commits 2
  • Pipelines 5
  • Changes 1

Cropping was not handled properly when the frames have to be copied to xvimage's buffer pool, first because the crop meta were dropped, and second because the allocated frame size in xvimage's buffer pool were smaller than the incoming frame.

This patch fixes the issue by not creating the xvimage's buffer pool in setcaps() virtual method, but it's delayed until show_frame() virtual method, when the buffer pool has to be used for copying the frame.

Also the xvimagesink's video info is updated when propose_allocation() virtual method is called.

cc: @ndufresne

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: xvimagesink-propose-allocation