Skip to content

Vulkan leak and swapper fixes

Matthew Waters requested to merge ystreet/gst-plugins-bad:vulkan into master

commit 8093bd73

vulkan/swapper: add a couple of missing g_clear_error()'s

commit f59c18ec

vulkan/build: conditionally depend on Vulkan-1.0.gir

Vulkan-1.0.gir is new in gobject-introspection >= 1.61.1

commit bc3010c9

vulkandisplay: silence an unused but set error with no enable winsys implementations

commit 7342adaa

vulkan/swapper: check queue present return later

During resizes, the VkQueuePresent can return OUT_OF_DATE and if a buffer
is displayed returning OUT_OF_DATE it would error out and stop the pipeline.

We already have a explicit check for OUT_OF_DATE and the same general
error check in the statements following so just use that code.

commit 0f3b0dd0

vulkan/swapper: destroy the surface in finalize

Fixes a leak of the VkSurface object.

commit db1a5505

vulkan/swapper: set some values to NULL in error conditions

So that they are not double free()-ed.

commit 3da0a33d

vulkancolorconvert: explicitly initalize swizzle arrays

Fixes uninitialized access of the indexed values larger than
the number of planes in the video format.

commit b3aba20e

vulkan/error: add the error value in hex and decimal

Provides more information for what may be an 'Unknown' error.

commit 874dcf57

vulkanswapper: disconnect window signals before any internal resources

Otherwise, it's racy whether the necessary resources are available in
the signal callbacks on destruction.

Merge request reports