Skip to content

srtpdec: Simplify status handling in gst_srtp_dec_decode_buffer

Jan Alexander Steffens requested to merge heftig/gst-plugins-bad:srtpdec-status into master
  • Simplify locking: don't drop the lock on filter just to unmap the buffer (or log a message).
  • Simplify checking the unprotect error: Introduce an err label to jump to. Avoid logging two warnings per failure.
  • Simplify code flow handling status_key_expired: Ensures a balanced UNLOCK -> LOCK.
  • Lower severity of srtp_err_status_replay_fail: AFAIU this happens when encountering retransmissions. Don't print a warning for these packets.
Edited by Jan Alexander Steffens

Merge request reports