Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • gst-plugins-bad gst-plugins-bad
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 973
    • Issues 973
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 101
    • Merge requests 101
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

Update #1:

Due to abusive users subverting our CI facilities to mine cryptocurrency, breaking out of the container sandbox in the process, we have been forced to take actions to limit the usage of the public runners to official projects only.

The policy will be enforced on 2023-03-23 (or before if we detect abuses).

Please see this issue for more context and to see if and how you are impacted.

  • GStreamerGStreamer
  • gst-plugins-badgst-plugins-bad
  • Merge requests
  • !2382

d3d11videosink: Some fixes for running in GstVideoOverlay mode

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Philipp Trommler requested to merge ferruck/gst-plugins-bad:master into master Jul 07, 2021
  • Overview 44
  • Commits 4
  • Pipelines 8
  • Changes 5

While trying to embed multiple GstD3D11VideoSinks as GstVideoOverlays into our GTK4 application, we've stumbled upon some issues that I'm trying to resolve with the attached patches. Namely these are:

  • Resizing of the overlays via gst_video_overlay_set_render_rectangle did not work
  • Creating multiple overlays in the same top level window has led to the original window procedure being irrecoverably lost
  • Additionally, when creating multiple overlays, only one would behave normally

I've worked on these patches on top of 1.18.4 but also tested them on top of 1.19.1 (both GStreamer itself as well es gst-plugins-bad). Testing was done with our GTK application and (to ensure the normal use-case wasn't accidentally broken) with the simple pipeline

 gst-launch-1.0 videotestsrc ! d3d11videosink

on Windows 10. I could reproduce the issues without and the fixes with my patches on both versions.

This is my first time working on both GStreamer plugins and the WIN32-API so it's well possible I've missed something, I'm especially unsure about that dead code removal. In that case I'm happy for any feedback and will adjust my patches accordingly.

Regarding the failed pipeline: I guess the issues are not in my code.

Edited Jul 07, 2021 by Seungha Yang
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master