tsmux: Recheck existing pad PIDs when requesting a new pad with a random pid

Previously pads might have been requested already (e.g. in NULL state), then reset was called (e.g. because changing state) and then a new pad was requested. Resetting is re-creating the internal muxer object and as such resetting the pid counter, so the next requested pad would get the same pid as the first requested pad which then leads to collisions.

---

CC @meh as this is apparently some fallout from creating the proper base class.

mentioned in merge request !2318 (merged)

added Regression label

assigned to @gstreamer-merge-bot

added 1.18 Needs backport labels

mentioned in commit slomo/gst-plugins-bad@127ade39

added 38 commits

• bce32e55...569910a5 - 37 commits from branch gstreamer:master
• 127ade39 - tsmux: Recheck existing pad PIDs when requesting a new pad with a random pid

Compare with previous version

I couldn't merge this branch: CI failed!

assigned to @gstreamer-merge-bot and unassigned @slomo

merged

mentioned in commit tpm/gst-plugins-bad@9a58b3b8

added Backported into 1.18 label and removed Needs backport label

Merge Request for backport into 1.18 branch: !2357 (merged) (target milestone: 1.18.5)

mentioned in merge request !2357 (merged)

changed milestone to %1.19.2